-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: add schema parsing to live collections #13763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
32750ec to
375d854
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few questions around the code. It would be great if the RFC would cover error handling
|
|
||
| export function isAstroError(e: unknown): e is AstroError { | ||
| return e instanceof AstroError; | ||
| return e instanceof AstroError || AstroError.is(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the AstroError is thrown inside the content config it's not recognising it as an instance of the AstroError class, so isn't giving the nicely-formatted error messages
Changes
Adds schema parsing to live content collections.
getCollectionandgetEntryTesting
Still needs tests
Docs
Added a new error