Skip to content

Conversation

@sijad
Copy link
Contributor

@sijad sijad commented May 9, 2025

Changes

ignore lightningcss unsupported pseudo-class warning. fixes #13658

Testing

there's no testing for logger

Docs

no need to updated docs, no affect on user’s behavior

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2025

🦋 Changeset detected

Latest commit: 608eb2a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 9, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 9, 2025

CodSpeed Performance Report

Merging #13773 will not alter performance

Comparing sijad:fix-lightningcss-warn (608eb2a) with main (3aa5337)

Summary

✅ 6 untouched benchmarks

@ematipico
Copy link
Member

Thank you @sijad , can you add a changeset? The contribution guide should tell you how

@sijad sijad force-pushed the fix-lightningcss-warn branch from 549ca75 to ccc50b1 Compare May 10, 2025 12:55
@sijad
Copy link
Contributor Author

sijad commented May 10, 2025

@ematipico added

@sijad sijad force-pushed the fix-lightningcss-warn branch from ccc50b1 to 8f348f5 Compare May 10, 2025 12:57
@ascorbic ascorbic merged commit 3aa5337 into withastro:main May 21, 2025
5 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 21, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
* ignore lightningcss global pseudo-class warning

* Update changeset

---------

Co-authored-by: Matt Kane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lightningcss warns (a lot) when using :global()

3 participants