Skip to content

Conversation

@L4Ph
Copy link
Contributor

@L4Ph L4Ph commented May 9, 2025

Changes

  • Fixed an issue where animation would stop when converting from GIF to WebP

fix #13683 #13689 #13741

Testing

I looked at all the previous commits and it seemed like there were no tests, so I didn't write any.
I'll write some if necessary.

Docs

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2025

🦋 Changeset detected

Latest commit: a2c059e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 9, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 9, 2025

CodSpeed Performance Report

Merging #13777 will not alter performance

Comparing L4Ph:gif-animation-would-not-loop (a2c059e) with main (9d49297)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt it's possible to test the final result, somehow. Did you test the fix manually?
I'll create a preview release so users can test it

@ematipico ematipico added the pr preview Apply this label to a PR to generate a preview release label May 10, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 10, 2025

astro

npm i https://pkg.pr.new/astro@13777

@astrojs/cloudflare

npm i https://pkg.pr.new/@astrojs/cloudflare@13777

@astrojs/netlify

npm i https://pkg.pr.new/@astrojs/netlify@13777

@astrojs/node

npm i https://pkg.pr.new/@astrojs/node@13777

@astrojs/vercel

npm i https://pkg.pr.new/@astrojs/vercel@13777

commit: 887157e

@L4Ph
Copy link
Contributor Author

L4Ph commented May 10, 2025

I doubt it's possible to test the final result, somehow. Did you test the fix manually?
I'll create a preview release so users can test it

Yes, I have confirmed that it is actually looping. (pnpm --filter @example/blog run build and preview)

@L4Ph
Copy link
Contributor Author

L4Ph commented May 10, 2025

https://github.com/L4Ph/astro-gif-animation-bug-repro
You can try it here.(I changed the file name because it was a hassle to have the cache used during the build.)

@ematipico ematipico merged commit a56b8ea into withastro:main May 13, 2025
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 13, 2025
@L4Ph L4Ph deleted the gif-animation-would-not-loop branch May 13, 2025 05:39
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
* feat(sharp): add support for converting animated GIFs to animated WebP

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pr preview Apply this label to a PR to generate a preview release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Astro converts looping animated gifs into non-looping webp

3 participants