Skip to content

Conversation

@Lofty-Brambles
Copy link
Contributor

Changes

  • This fixes the newlines and unsupported list syntax in the mermaid diagram in the CONTRIBUTING.md file. Seemed like a tiny change, unnecessary to open an issue for.

Before

graph TD;
    start{Followed issue\ntemplate?}
    start --NO--> close1[Close and ask to\nfollow template]
    start --YES--> dupe{Is duplicate?}
    dupe --YES--> close2[Close and point\nto duplicate]
    dupe --NO--> repro{Has proper\nreproduction?}
    repro --NO--> close3[Label: 'needs reproduction'\nbot will auto close if no update\nhas been made in 3 days]
    repro --YES--> real{Is actually a bug?}
    real --NO--> maybefeat{Is it a feature request?}
    maybefeat -- YES --> roadmap[Close the issue.\n Point user to the roadmap.]
    maybefeat -- NO --> intended{Is the intended\nbehaviour?}
    intended --YES--> explain[Explain and close\npoint to docs if needed]
    intended --NO--> open[Add label 'needs discussion'\nRemove 'needs triage' label]
    real --YES--> real2["1. Remove 'needs triage' label\n2. Add related feature label if\napplicable (e.g. 'feat: ssr')\n3. Add priority and meta labels (see below)"]
    real2 --> tolabel[Use the framework below to decide the priority of the issue,\nand choose the correct label]
Loading

After

graph TD;
    start{Followed issue <br/> template?}
    start --NO--> close1[Close and ask to <br/> follow template.]
    start --YES--> dupe{Is duplicate?}
    dupe --YES--> close2[Close and point <br/> to duplicate.]
    dupe --NO--> repro{Has proper <br/> reproduction?}
    repro --NO--> close3[Add&nbsp;label:&nbsp;'needs&nbsp;discussion'. <br/> Bot will auto close if no <br/>update was made in 3 days.]
    repro --YES--> real{Is actually a bug?}
    real --NO--> maybefeat{Is it a feature request?}
    maybefeat -- YES --> roadmap[Close the issue. <br/> Point user to the roadmap.]
    maybefeat -- NO --> intended{Is the intended <br/> behaviour?}
    intended --YES--> explain[Explain and close. <br/> Point to docs if needed.]
    intended --NO--> open[Add&nbsp;label:&nbsp;'needs&nbsp;discussion'.<br/>Remove&nbsp;label:&nbsp;'needs&nbsp;triage'.]
    real --YES--> real2["∙&nbsp;Remove&nbsp;label:&nbsp;'needs&nbsp;triage'. <br/> ∙ Add related feature label if <br/> applicable. (e.g. 'feat: ssr') <br/> ∙ Add priority and meta labels. (see below)"]
    style real2 text-wrap:balance
    real2 --> tolabel[Use the framework below <br/> to decide the priority <br/> of the issue and choose <br/> the correct label.]
Loading

Testing

Does not need a text - simple syntax fix in the markdown for a mermaid diagram.

Docs

Doesn't affect the user.

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2025

⚠️ No Changeset found

Latest commit: 695d4de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@ematipico ematipico merged commit 30ea005 into withastro:main May 12, 2025
2 checks passed
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants