fix(fonts): take build config into account #13784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa4db65 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #13784 will not alter performanceComparing Summary
|
ematipico
approved these changes
May 12, 2025
Comment on lines
+83
to
+86
| const assetsDir = prependForwardSlash( | ||
| appendForwardSlash(joinPaths(settings.config.build.assets, ASSETS_DIR)), | ||
| ); | ||
| const baseUrl = joinPaths(settings.config.base, assetsDir); |
There was a problem hiding this comment.
Why don't we remove the trailing slash anymore? Also, the comment must be updated. Line 82 still talks about trailing slash
There was a problem hiding this comment.
I've updated the comment thanks! We don't need to care about the trailing slash here anymore because this is handled by each UrlResolver (which use joinPaths() under the hood)
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
config.build.assetsandconfig.build.assetsPrefixinto account. This required updating most paths handling as it was not robust enoughTesting
Docs
Changeset