Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented May 12, 2025

Changes

  • Until now, types under packages/astro/components have always been hard to work with
  • Now, TS works correctly there and .astro files are checked using @astrojs/check
  • For context, that's convenient for the Font component because I need "complex" types from a virtual module

Testing

Manually:

  • I ran pnpm build locally without issues
  • I run pnpm pack in packages/astro to make sure we don't export unwanted files (eg. components/tsconfig.json)

Docs

N/A

@florian-lefebvre florian-lefebvre self-assigned this May 12, 2025
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2025

⚠️ No Changeset found

Latest commit: 8bc0689

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 12, 2025
@florian-lefebvre florian-lefebvre marked this pull request as draft May 12, 2025 12:24
@florian-lefebvre florian-lefebvre marked this pull request as ready for review May 12, 2025 12:48
@florian-lefebvre florian-lefebvre merged commit e7e32eb into main May 12, 2025
5 checks passed
@florian-lefebvre florian-lefebvre deleted the chore/typecheck-components branch May 12, 2025 16:01
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants