Skip to content

fix(fonts): properly throw error #13788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

fix(fonts): properly throw error #13788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
884b60a
fix(fonts): properly throw error
florian-lefebvre May 12, 2025
373268a
Merge branch 'main' into fix/fonts-unavailable-error
florian-lefebvre May 12, 2025
1e2e199
fix: tests
florian-lefebvre May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/petite-rockets-relax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes a case where an error would not be thrown when using the `<Font />` component from the experimental fonts API without adding fonts in the Astro config
8 changes: 5 additions & 3 deletions packages/astro/components/Font.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
---
import { AstroError, AstroErrorData } from '../dist/core/errors/index.js';
import * as mod from 'virtual:astro:assets/fonts/internal';

// TODO: remove dynamic import when fonts are stabilized
const { fontsData } = await import('virtual:astro:assets/fonts/internal').catch(() => {
// TODO: remove check when fonts are stabilized
const { fontsData } = mod;
if (!fontsData) {
throw new AstroError(AstroErrorData.ExperimentalFontsNotEnabled);
});
}

interface Props {
/** The `cssVariable` registered in your Astro configuration. */
Expand Down