-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: adds support for rendering markdown in loaders #13850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1abbbb1
wip: loader markdown support
ascorbic 2c2d474
Better name
ascorbic f64b8b8
Add tests and docs
ascorbic 52d19be
Lint
ascorbic 6a93e92
Remove options
ascorbic d0fd499
Merge branch 'main' into loader-md
ascorbic 6d68f2e
Lint
ascorbic 1107574
Apply suggestions from code review
ascorbic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| --- | ||
| 'astro': minor | ||
| --- | ||
|
|
||
| Provides a markdown renderer to content loaders | ||
|
|
||
| When creating a content loader, you will now have access to a `renderMarkdown` function that allows you to render markdown content directly within your loaders. It uses the same settings and plugins as renderer used for markdown files in Astro, and follows any markdown settings you have configured in your Astro project. | ||
ascorbic marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| This allows you to render markdown content from various sources, such as CMS or other data sources, directly in your loaders without needing to preprocess the markdown content separately. | ||
ascorbic marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ```ts | ||
| import type { Loader } from 'astro/loaders'; | ||
| import { loadFromCMS } from './cms'; | ||
|
|
||
| export function myLoader(settings): Loader { | ||
| return { | ||
| name: 'my-loader', | ||
| async load({ renderMarkdown, store }) { | ||
| const entries = await loadFromCMS(); | ||
|
|
||
| store.clear(); | ||
|
|
||
| for (const entry of entries) { | ||
| // Assume each entry has a 'content' field with markdown content | ||
| store.set(entry.id, { | ||
| id: entry.id, | ||
| data: entry, | ||
| rendered: await renderMarkdown(entry.content), | ||
| }); | ||
| } | ||
| }, | ||
| }; | ||
| } | ||
| ``` | ||
|
|
||
| The return value of `renderMarkdown` is an object with two properties: `html` and `metadata`. These match the `rendered` property of content entries in content collections, so you can use them to render the content in your components or pages. | ||
|
|
||
| ```astro | ||
| --- | ||
| import { getEntry, render } from 'astro:content'; | ||
| const entry = await getEntry('my-collection', Astro.params.id); | ||
| const { Content } = await render(entry); | ||
| --- | ||
| <Content /> | ||
| ``` | ||
ascorbic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.