Skip to content

Stabilize live collections #14550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Stabilize live collections #14550

wants to merge 5 commits into from
+89 −38

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Oct 16, 2025 •
edited by sarah11918
Loading

Changes

Removes the experimental.liveContentCollections flag and enables it for all sites.

Closes #14376

Testing

Updated test fixture

Docs

Added changeset. It doesn't have any links to docs, because I'm not sure where they'll live.

EDITED BY SARAH:

@withastro/maintainers-docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 89cb2fa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) docs pr labels Oct 16, 2025
florian-lefebvre
florian-lefebvre approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see such a small PR!

sarah11918
sarah11918 reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! And if anything gets a pass at not being a minimal changeset, it's this one! (It won't really be in the upgrade guide at all other than removing the experimental flag, so it should shine here.)

Some tiny comments below!

yanthomasdev
yanthomasdev reviewed Oct 16, 2025
View reviewed changes
@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Oct 16, 2025
yanthomasdev
yanthomasdev reviewed Oct 16, 2025
View reviewed changes
.changeset/stale-ads-see.md Outdated
});
```

No other changes to your project code are required as long as you have been keeping up with Astro 5.x patch releases which may have contained breaking changes to this experimental feature. If you experience problems with your live collections after upgrading to Astro v6 and removing this flag, please review the [Astro CHANGELOG from 5.10.2](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md#5102) onwards for any potential updates you might have missed, or follow the [current v6 documentation for live collections](https://docs.astro.build/en/guides/content-collections/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may have contained breaking changes to this experimental feature

What do we mean by "may"? We don't know if there were breaking changes to the feature? I feel like we could be clearer here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair! I think I saw an update in 5.10.2 (so you no longer specify a live type of collection) and there's a current breaking change PR we just reviewed (not sure if going out in a 5.14 patch, or will wait for 5.15.0) that for sure is a breaking change).

This is kind of generic language, because I also don't know what other breaking changes might come up between now and then. But in fact, we could just take out the words "may have" and it would be correct!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the "may have". There were breaking changes in some of them.

ascorbic and others added 2 commits October 16, 2025 19:41
@ascorbic @yanthomasdev
Apply suggestions from code review
d3bc6ab 
Co-authored-by: Yan <[email protected]>
@ascorbic
Clarify changes needed for Astro 6 upgrade
89cb2fa 
Updated the note regarding changes required for Astro 6.
@github-actions GitHub Actions
Copy link
Contributor

📝 Changeset Validation Results

❌ Changeset validation failed

Issues Found:

.changeset/stale-ads-see.md

Issue with: '#### Live collections vs build-time collections'

❌ Incorrect use of heading level that can disrupt changelog rendering.

💡 Suggestions:
• Use headings like #### or ##### instead to avoid rendering issues.
• Reformat this section, for example:

#### Live collections vs build-time collections

📖 See Astro's changeset guide for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@yanthomasdev yanthomasdev yanthomasdev left review comments

@ematipico ematipico ematipico approved these changes

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

Assignees

@ascorbic ascorbic

Labels

docs pr pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ascorbic @ematipico @sarah11918 @yanthomasdev @florian-lefebvre