-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Switch to OIDC for npm publishing #14565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me now and matches what I've been doing so far 👍
I guess a remaining question could be whether this needs a changeset or not, is this a change we may want to inform users about?
No, this is a change to how we publish packages, it shouldn't cause users to have to upgrade any packages. |
Yeah, was looking at what we did when we added provenance by curiosity, it was a patch to all packages. Also looking at that old change, we could technically also remove the |
I’d be +1 on making it a patch for all packages: it would ensure securely published versions of everything go out now rather than only being published next time there’s a change to a package. Users wouldn’t have to upgrade, but they could if they wanted. |
Changes
Testing
N/A
Docs
N/A