Skip to content

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Oct 21, 2025

Changes

This PR ensures that the SKIP_OG and PUBLIC_TWO_LANG environment variables are passed through during the Astro Docs smoke test build process.

As visible in these recent docs smoke test logs, when expanding the Test step, and expanding the docs:build section, Astro Docs is being built for all languages and includes Open Graph image generation.

This should not be the case as we specifically set the SKIP_OG and PUBLIC_TWO_LANG environment variables to skip OG generation and build only two languages.

I assume this broke with Turborepo 2.0:

Strict Mode for environment variables is now the default, moving from Loose Mode

Strict Mode filters the environment variables available to a task's runtime to only those that are specified in turbo.json.

This PR adds the two environment variables to the passThroughEnv array for the build task used in the smoke tests.

Testing

I tested a simplified version of the action locally to confirm that the environment variables are now correctly passed through and the docs smoke test in this PR confirms the fix.

Docs

None, internal CI change only.

Copy link

changeset-bot bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: c308b94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HiDeoo HiDeoo marked this pull request as ready for review October 21, 2025 13:08
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @HiDeoo and good work spotting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants