Draft
Conversation
🦋 Changeset detectedLatest commit: 4092385 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will improve performance by 12.16%
Performance Changes
Comparing Footnotes |
ac633da to
9bd2e2c
Compare
9bd2e2c to
4092385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a race condition in the dev server that could cause
TypeError: Missing parametererrors when handling concurrent requests to dynamic routes.The
resolvedPathnamewas stored as shared instance state onAstroServerAppandDevApp, so concurrent requests could overwrite each other's pathname, causing a mismatch between the matched route and the pathname used to extract params.This PR changes it to use a local variable per-request.
Claude was involved in the diagnosis of this bug and the creaiton of the fix.
Testing
Added a test
Docs