Skip to content

chore: remove fixtures and move slot tests to unit#16773

Open
ematipico wants to merge 4 commits into
mainfrom
refactor/integration-to-unit
Open

chore: remove fixtures and move slot tests to unit#16773
ematipico wants to merge 4 commits into
mainfrom
refactor/integration-to-unit

Conversation

@ematipico
Copy link
Copy Markdown
Member

@ematipico ematipico commented May 18, 2026

Changes

  • Removed old fixtures
  • Tests involved Astro slots have been moved to unit tests. I used the compiled components, so that we don't need to rely on the vite plugin or the compiler itself.
  • Rewrite tests were redundant. They are about routing, and the dev server doesn't have anything to do with it.
  • Custom 500 tests were moved to unit tests
  • Client address tests were moved to unit tests

Testing

Green Ci

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 18, 2026

⚠️ No Changeset found

Latest commit: 7a13de7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label May 18, 2026
@ematipico ematipico marked this pull request as ready for review May 19, 2026 09:41
/**
* `Slotted.astro` — three named slots (a, b, c) + default, always rendered.
*/
const Slotted = createComponent((result: any, _props: any, slots: any) => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think you need the any there (and in other spots)? Some other tests don't have them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants