Skip to content

Populate external stylesheet URLs for prerendered routes in manifest #16813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewp wants to merge 3 commits into
base: 5-legacy
Choose a base branch
from
+39 −2
Open

Populate external stylesheet URLs for prerendered routes in manifest #16813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f60466
Populate external stylesheet URLs for prerendered routes in manifest
matthewp May 20, 2026
ece4cc5
Add 5-legacy to preview release workflow branches
matthewp May 20, 2026
8085fe1
Add test for prerendered route styles in manifest
matthewp May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/deep-spies-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Populates styles in the SSR manifest for prerendered routes. Previously, prerendered routes had `styles: []` in the manifest, making it impossible for workers or middleware to discover which CSS files a prerendered page uses.
2 changes: 1 addition & 1 deletion .github/workflows/preview-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Preview release

on:
pull_request:
branches: [main]
branches: [main, 5-legacy]
types: [labeled]

concurrency:
Expand Down
12 changes: 11 additions & 1 deletion packages/astro/src/core/build/plugins/plugin-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,21 @@ async function buildManifest(
const outFolder = getOutFolder(opts.settings, route.pathname, route);
const outFile = getOutFile(opts.settings.config, outFolder, route.pathname, route);
const file = outFile.toString().replace(opts.settings.config.build.client.toString(), '');

const pageData = internals.pagesByKeys.get(makePageDataKey(route.route, route.component));
const styles = pageData
? pageData.styles
.sort(cssOrder)
.map(({ sheet }) => sheet)
.map((s) => (s.type === 'external' ? { ...s, src: prefixAssetPath(s.src) } : s))
.reduce(mergeInlineCss, [])
: [];

routes.push({
file,
links: [],
scripts: [],
styles: [],
styles,
routeData: serializeRouteData(route, settings.config.trailingSlash),
});
staticFiles.push(file);
Expand Down
9 changes: 9 additions & 0 deletions packages/astro/test/fixtures/ssr-manifest/src/pages/prerendered.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
export const prerender = true;
import '../styles/global.css';
---

<html>
<head><title>Prerendered</title></head>
<body><p>Hello</p></body>
</html>
1 change: 1 addition & 0 deletions packages/astro/test/fixtures/ssr-manifest/src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
body { color: red; }
12 changes: 12 additions & 0 deletions packages/astro/test/ssr-manifest.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ describe('astro:ssr-manifest', () => {
assert.equal(app.manifest.compressHTML, true);
});

it('includes styles for prerendered routes in manifest', async () => {
const app = await fixture.loadTestAdapterApp();
const prerenderedRoute = app.manifest.routes.find(
(route) => route.routeData.route === '/prerendered',
);
assert.ok(prerenderedRoute, 'prerendered route should be in manifest');
assert.ok(
prerenderedRoute.styles.length > 0,
'prerendered route should have styles in manifest',
);
});

it('includes correct routes', async () => {
const app = await fixture.loadTestAdapterApp();
// NOTE: `app.manifest` is actually a private property
Expand Down
Loading