fix(cli): Add project name normalization in astro add cloudflare#16816
Open
dario-piotrowicz wants to merge 1 commit into
Open
fix(cli): Add project name normalization in astro add cloudflare#16816dario-piotrowicz wants to merge 1 commit into
astro add cloudflare#16816dario-piotrowicz wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 7d26950 The changes in this PR will be included in the next version bump. This PR includes changesets to release 415 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
matthewp
reviewed
May 21, 2026
| const data = await getPackageJson(); | ||
| let compatibilityDate = new Date().toISOString().slice(0, 10); | ||
|
|
||
| // Normalize the project name, in the same way Wrangler does: https://github.com/cloudflare/workers-sdk/blob/e04e180d/packages/wrangler/src/autoconfig/details/index.ts#L360-L368 |
Contributor
There was a problem hiding this comment.
can you put this into a separate function?
ematipico
requested changes
May 22, 2026
Comment on lines
+5
to
+7
| Add project name normalization in `astro add cloudflare` | ||
|
|
||
| When `astro add cloudflare` generates a Wrangler config, the project name from `package.json` is now normalized to comply with Cloudflare's naming rules. Underscores are replaced with dashes, special characters are removed, leading/trailing dashes are trimmed, and the name is truncated to 63 characters. Previously, names like `my_project!` would be written as-is, causing Wrangler to reject the config. |
Member
There was a problem hiding this comment.
Please reword the changeset. It's too lengthly and it contains particulars that aren't that useful to users. Here's a guide https://contribute.docs.astro.build/docs-for-code-changes/changesets/#tips-and-examples
| const data = await getPackageJson(); | ||
| let compatibilityDate = new Date().toISOString().slice(0, 10); | ||
|
|
||
| // Normalize the project name, in the same way Wrangler does: https://github.com/cloudflare/workers-sdk/blob/e04e180d/packages/wrangler/src/autoconfig/details/index.ts#L360-L368 |
Member
There was a problem hiding this comment.
Please address @matthewp 's comment, and unit test the function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
namefield of wrangler.jsonc files thatastro add cloudflarecreates, ensuring that even if a project has a name incompatible with Cloudflare Worker's name constraint the command still produces a working projectTesting
npm create astrocalled"astro.app", I runnpx astro add cloudflareon it and it generated a wrangler.jsonc file with the invalid name"astro.app", then I locally build astro and retried again with my version and the name in the wrangler.jsonc is now a correct"astro-app"astro add cloudflarecommand doesn't seem to be test coveredDocs
This is a self explanatory/minimal fix