feat: add unsafeInline option to CSP style config#16822
Open
edmelly wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 4311f70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 415 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds
styleDirective.unsafeInlineopt-in flag to Astro's CSP configuration (fixes #14798).Per the CSP spec, browsers silently ignore
unsafe-inlinewhen hashes or nonces are present in the same directive. This meant users who neededunsafe-inlinefor styles (e.g. third-party libraries, inline style attributes) were forced to abandon Astro's CSP feature entirely — losing script hashing in the process.When
styleDirective.unsafeInline: trueis set:unsafe-inlinein style-src instead of style hashesTesting
Unit tests added in
test/units/csp/rendering.test.tscovering:unsafe-inlineis emitted and style hashes are omitted when the flag is setunsafe-inline) is unchangedDocs
The
unsafeInlineproperty is documented inline inconfig.tsalongside the existing hashes and resources properties. TheCspStyleDirectiveexported type is also updated./cc @withastro/maintainers-docs for feedback!