Clean up CSS HMR invalidation tests#16824
Open
thelazylamaGit wants to merge 13 commits into
Open
Conversation
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets astro-bot’s branch for #16783 and applies the requested CI/test clean up + a small dev-server regression test for the actual stale inline CSS behaviour. It does not change the fix implementation.
Changes
idToModuleMap: new Map()to the existinghmr-reload.test.tsmock so it matches the new module graph iteration added in Fix stale inline CSS in server-rendered HTML during dev #16783.Functioncast inhmr-css-invalidation.test.tswith a local typed hot update handler helper.getStaticPaths()route, edits global CSS, then verifies the next SSR response contains updated inline CSS.Testing
Test (astro)failure caused by the mockedenvironment.moduleGraphmissingidToModuleMap.@typescript-eslint/no-unsafe-function-type.virtual:astro:dev-css:*module graph invalidation.fixture.fetch(), andfixture.editFile().Docs
No docs changes needed. This only fixes internal dev-server HMR cache invalidation behavior and test coverage.