You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here is Claude's summary of the observable changes to end-users as a result of updating to v4.3.0:
Numbers with underscores no longer parse as numbers. count: 1_000 in frontmatter previously produced the number 1000; it now produces the string "1_000". This is js-yaml aligning with the YAML 1.2 spec, but it's a silent type change for any user relying on the old (nonstandard) behavior.
Stricter rejection of malformed input. Top-level block scalars without content indentation are now rejected, and YAML nested deeper than 100 levels now throws (the new maxDepth default). Documents that previously loaded — even if technically malformed — can now error.
Edge-case parse output changes from the correctness fixes: implicit block mapping key property parsing, trailing-whitespace folding in folded/flow scalars. Documents that were previously misparsed will now parse differently (correctly, but differently).
Merge-key limits could theoretically reject documents with pathological numbers of << merges, though anything hitting those limits was likely a DoS vector anyway.
A downstream data point, in case it helps this land: bun audit on an Astro site still reports GHSA-52cp-r559-cp3m through astro › js-yaml@4.2.0 on a current install.
The ^4.1.1 range does already allow 4.3.0, so this can look unnecessary at first glance. But a lockfile entry is only re-resolved once it stops satisfying the range, so every project that already has 4.2.0 locked keeps installing it. Bumping the minimum, as this PR does, is what actually propagates the patch downstream.
I hit the same situation with svgo (GHSA-2p49-hgcm-8545) and opened #17531 for it. Those are the two high advisories currently reaching Astro users through direct dependencies. Both are independent of the js-yaml v5 work in #17442.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg: astroRelated to the core `astro` package (scope)
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a
highsecurity advisory on js-yaml that is resolved by v4.3.0: GHSA-52cp-r559-cp3mI see that updating to v5 series might take some time, so in the meantime it would be valuable to update to 4.3.0 to resolve the security advisory if possible.
Here is Claude's summary of the observable changes to end-users as a result of updating to v4.3.0: