Make triage bot changesets non-optional - #17475
Draft
matthewp wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Triage-bot PRs frequently ship without a changeset. Root cause is in the skill instructions, which treat the changeset as a discretionary step the LLM can rationalize away for "trivial" fixes.
triage/fix.mdStep 9: reframed from "only do this if..." to required for any successful fix that modifies a package, with an explicit guard that one-line/type-only fixes still need one. Inlined thepnpm changeset --emptycommands so no second skill-load is needed.triage/fix.mdOutput: removed the "if no changeset was created, explain why" escape hatch.triage/fix.mdCleanup: added a gate — the finalgit statusmust include exactly one new.changeset/*.md.astro-pr-writer: backstop turned from passive ("check it exists") to active ("create it now if missing; don't post without one").Testing
Docs