fix(create-astro): create astro uses correct project name when using directory "." - #17477
Open
alexanderdombroski wants to merge 2 commits into
Open
fix(create-astro): create astro uses correct project name when using directory "."#17477alexanderdombroski wants to merge 2 commits into
alexanderdombroski wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: ed91702 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: create-astro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When running
npm create astro@latestand then using.for the output directory, Astro generates a package.json with an empty""package name. In contrast, runningnpm create astro .uses the current working directory's basename.This PR makes both invocation styles behave consistently by always deriving the package name from the generated project's basename. This behavior is also consistent with Vite's, Nuxt's, and Next's
npm createcommands.Before / After
Testing
I tested locally and added tests for
npm create astrowith dot for the project location prompt.Docs
Sufficient docs exist for the create astro command.