feat(create-astro): add nub package manager support - #17487
Open
colinhacks wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: c8dc949 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
create-astroalready detects nub as the active package manager (fromnpm_config_user_agent) and drives it correctly for install andastro addvia the generic passthrough andnub dlx. Two printed run commands were still wrong for nub:next-steps.ts— thecommandMaphad nonubentry, so nub users fell back tonpm run dev. Addednub: 'nub run dev'.template.ts(processTemplateReadme) — the non-npm path replacednpm runwith the bare package-manager name, turningnpm run devintonub dev. nub has no implicit script shortcut, so that is invalid. It now mapsnpm run <script>tonub run <script>, keeping the explicitrun.pnpm/yarn/bun output is unchanged. Changeset included.
Testing
Verified the code path a nub user hits: detection yields
packageManager === 'nub',commandMap.nubreturnsnub run dev, andprocessTemplateReadmerewritesnpm run devtonub run devwhile leaving barenpm(e.g.npm install->nub install) and the pnpm/yarn/bun branches untouched.Docs
No docs change needed — this only corrects the package-manager commands
create-astroprints for an already-detected manager.