fix: prevent ENOENT crash from IDE temporary files during file save - #17559
Open
bl3g2u4353ubgx6l-rgb wants to merge 2 commits into
Open
fix: prevent ENOENT crash from IDE temporary files during file save#17559bl3g2u4353ubgx6l-rgb wants to merge 2 commits into
bl3g2u4353ubgx6l-rgb wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: c1f079a The changes in this PR will be included in the next version bump. This PR includes changesets to release 399 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fs.existsSync(resolved)check before callingfs.statSync(resolved).isDirectory().ENOENTerror. This occurs because some IDEs create and rapidly delete temporary files during the save process. If the temporary file is deleted just beforefs.statSyncis executed, it causes an error. This extra check prevents the crash.Testing
Manually tested by modifying and saving files using an IDE in a local environment. Verified that the dev server/watcher no longer crashes with an
ENOENTerror when temporary files are rapidly created and deleted.Docs
No docs added. This is a purely internal bug fix to improve stability during file watching and does not affect any user-facing APIs or behaviors.