fix: multiline component attributes#37
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 4856182 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an
Unterminated string literalerror when a quoted attribute on a component contains literal newlines — e.g. a multi-lineclass=""produced byprettier-plugin-classnames.Component attributes are emitted into a JS props object (
{ "class": "..." }). A raw\ninside that string literal is invalid JS and breaks the generated module.escape_newlineshelper inprinter/escape.rs, mirroring the Go compiler'sescapeNewlines(\n→\n,\r→\r).escape_double_quotesin the two component props-object paths incomponents.rs: the scoped-classmerge and the general quoted-attribute case. Matches the Go compiler's single use ofescapeNewlinesinprintAttributesToObject.Testing
escape_newlines(LF, CR, CRLF, multi-line class, no-op).multiline_class_attribute_on_component.astrocovering the motivating case.Docs
Bug fix only, no docs needed.