-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(actions): add note about enctype="multipart/form-data" for file … #11397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Thanks for the suggestion for docs! It feels a little rough on the reader to try to shove extra "oh, by the way!" facts at them before they've even seen the basic code snippet, though. What would you think about, after the existing log out button example, a second example. This way, we don't have to cram stuff into a tight paragraph, but can show an example of submitting a form. I could see something like (just really rough wording off the top of my head):
What do you think about a format like that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in terms of correctness!
I don't mind @sarah11918, feel free to change it whatever you think works :) I just came across the issue and took a while to figure out why it didn't work so thought it should be in the docs for other 👍 |
@gilesbutler Would you like to update the text and provide the example? Or would you like someone else to jump in here now? 😄 |
Hey @sarah11918 I don't mind at all 😊 You probably have a better idea of what works with your experience on the product but I can take a look next week if not. |
It's been a busy launch week, so we haven't had much time to follow up here! If you're still interested, would love for you to continue with this @gilesbutler ! |
Description (required)
Adds a note to the Astro Actions documentation explaining that forms containing file uploads must include enctype="multipart/form-data" for file inputs to be parsed correctly. This is necessary for validation using z.instanceof(File) to work as expected with schema validation libraries like Zod.
Related issues & labels (optional)
Suggested label: area: docs