-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(fonts): warn if local font is in public dir #11511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The content seems right to me. But perhaps we don't need a callout here and we should say that in a paragraph above the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally sure this rises to a caution, but I don't hate it so we'll let it stand! 😄
I think the comment is in the right spot, and just left an idea for maybe adding a bit of an explanation!
Co-authored-by: Sarah Rainsberger <[email protected]>
|
It may not require a callout there but I think it's helpful, especially for people migrating from manual usage to this API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, Thank you!
Description (required)
Related issues & labels (optional)
For Astro version:
5.7.6. See astro PR withastro/astro#13678