Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.7.6. See astro PR withastro/astro#13678

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 23, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 165443f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6809db8a3fa5680008af1bcd
😎 Deploy Preview https://deploy-preview-11511--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArmandPhilippot
Copy link
Member

The content seems right to me. But perhaps we don't need a callout here and we should say that in a paragraph above the Tabs:

Defines the font sources. The value can be a path relative to the root, a package import or a URL. URLs are particularly useful if you inject local fonts through an integration.

Fonts should be stored in another location than /public as this will result in duplicated files in your build output. You can store them inside /src for example.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure this rises to a caution, but I don't hate it so we'll let it stand! 😄

I think the comment is in the right spot, and just left an idea for maybe adding a bit of an explanation!

@florian-lefebvre
Copy link
Member Author

It may not require a callout there but I think it's helpful, especially for people migrating from manual usage to this API

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Thank you!

@florian-lefebvre florian-lefebvre merged commit 0718dec into main Apr 24, 2025
10 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-warn-public-dir branch April 24, 2025 13:25
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants