-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: experimental CSP docs #11736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: experimental CSP docs #11736
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
That's huge, cool and elegant solution that covers 90% of my needs. Great job @ematipico! I will use your solution for google analytics, comments and styles. And Zaraz for the rest (which is ad placement, cause those are added on top of a built website and need nonces). |
Co-authored-by: Sarah Rainsberger <[email protected]>
|
Not a direct change request, but the client router being incompatible (as discussed in the API bash) isn't mentioned anywhere yet, so that'd be nice to include. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nits regarding some types, otherwise LGTM (including Sarah's suggestions). Great job Ema!
Co-authored-by: Armand Philippot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't pay attention to that earlier, but I believe there is a typo each time we use style-src. According to Syntax on MDN or Content Security Policy (CSP) Quick Reference Guide, style-src is not different from the other directives: no colon, only a space.
Otherwise, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things my ocd flagged flagged for me 😄
Co-authored-by: Matthew Justice <[email protected]> Co-authored-by: Armand Philippot <[email protected]>
Description (required)
This PR adds a new page under the experimental section that documents the upcoming CSP support.
For Astro version:
5.9.0. See astro PR #13802 and the docs/changeset PR #13870I leave here the link to RFC too: https://github.com/withastro/roadmap/blob/feat/rfc-csp/proposals/0055-csp.md