Skip to content

Conversation

@mocdaniel
Copy link
Contributor

Description (required)

Adds German translation for upgrade-astro.mdx and proposes a few new words for the German i18n style guide.

To reviewers: Ich war mir bei einigen Begriffen aus dem Tech-Jargon nicht sicher, ob/wie ich sie übersetzen soll. Einen Teil davon habe ich für das Glossar vorgeschlagen, den Rest (der vmtl. nicht so oft vorkommt) frei Schnauze (aber konsistent) übersetzt. Schaut da also gerne besonders drauf.

Viel Spaß beim Typos finden!

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a559a0f
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/697b7c251753310008abfa38
😎 Deploy Preview https://deploy-preview-13126--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 24, 2026
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 24, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/upgrade-astro.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless
Copy link
Contributor

Thanks for the addition!

I haven't looked through it yet, but I wanted to give you a little hint regarding the one failing GitHub check. I don't know if you have noticed it already, but we automatically validate all the links between Astro docs pages to make sure that we don't make typos that would lead to invalid links.

This validation check then shows a pretty nice output, as you can see here:

image

You can also find these logs here (which can be accessed by also clicking on the checks tab in this PR or on the red check in the … let's call it "merge box" at the bottom of this page).

In general, we have these rules for translations:

  • All links of a translation should stay in the same locale, meaning that we - in German translations - must link to e.g. /de/guides/upgrade-to/v5 instead of /en/guides/upgrade-to/v5. This applies even when the page we link to does not exist in German yet because Starlight (the integration handling all the page generation from Markdown) automatically falls back to the default - in this case the English - version.
  • If the link includes a hash/fragment (e.g. #html-components), then we must look if the page is already translated or not. If it is, we must link to the German hash (e.g. #html-komponenten), and if not, we must link to the English version (e.g. #html-components) until we translate the page.

It could very well be that you already know this stuff. I'm sorry if I bored you. But I thought I might explain it in detail in case you were not aware already 👍

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, you really did an amazing job sticking to the guidelines. I can't express how well-made this translation really is ❤️

I left some comments below with possible improvements, mostly small things were a rephrasing could improve readability and comprehension. All-in-all I really have to thank you for your motivation and dedication.

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, some complimenting the existing comments left by Felix.

Some of them are simple errors that make sense to fix, like the missing starting quote. Others require opinions.

@mocdaniel
Copy link
Contributor Author

I added most of the suggestions from your first reviews to the PR, except for the unresolved discussions around breaking change and deprecation/deprecate.

I also added to release to the glossary, as I thought it'd be covered by this paragraph from the style guide, so maybe listing it explicitly might be useful to others:

Wir übersetzen nicht zwanghaft Begriffe, die aus einem Ökosystem-spezifischen Kontext stammen. Eine Wort für Wort Übersetzung ist meistens nicht möglich, sodass eine ausführliche Erklärung folgen müsste, was wiederum die Lesbarkeit verschlechtert. Ein gutes Beispiel hierfür wären Begriffe, wie „Commit“, „Pull Request“ und „merge“, die teils einen ganzen Prozess im Git-Ökosystem beschreiben.

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Ich habe noch einige Änderungen vorgeschlagen. Eines davon ist ein Beschreibungsfehler im Glossar, das andere ist nur ein Kommasetzungsfehler.

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es gibt etwas, wozu wir mehr Meinungen brauchen. Das können wir wahrscheinlich besser in Discord besprechen statt hier, wenn nötig.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some more comments (the suggested changes to the glossary will make change when you first look at the comments in the text), some of them are nitpicky, some opinionated and some fix basic oversights. No rush!

Otherwise, I think we are almost good to approve, I think most discussions are cleared and we have agreed on one opinion 👍

Feel free to request a review again when all comments are resolved (I think some others from randomguy can also be marked as completed already, I just don't have permission)

@mocdaniel mocdaniel force-pushed the add-upgrade-astro-de branch from 771c69b to a559a0f Compare January 29, 2026 15:26
@mocdaniel
Copy link
Contributor Author

I added most pending suggestions. @trueberryless care to take another look at the changes and the two unresolved discussions?

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

AFAIK all comments and discussions are resolved and we are good to merge, once randomguy approves as well. GitHub shows some random threads for some reason, I'm just gonna ignore them as I think we have everything, right? EDIT: I think GitHub doesn't let me resolve my own comment… Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants