-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
i18n(de): add upgrade-astro.mdx translation
#13126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Thanks for the addition! I haven't looked through it yet, but I wanted to give you a little hint regarding the one failing GitHub check. I don't know if you have noticed it already, but we automatically validate all the links between Astro docs pages to make sure that we don't make typos that would lead to invalid links. This validation check then shows a pretty nice output, as you can see here:
You can also find these logs here (which can be accessed by also clicking on the checks tab in this PR or on the red check in the … let's call it "merge box" at the bottom of this page). In general, we have these rules for translations:
It could very well be that you already know this stuff. I'm sorry if I bored you. But I thought I might explain it in detail in case you were not aware already 👍 |
trueberryless
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, you really did an amazing job sticking to the guidelines. I can't express how well-made this translation really is ❤️
I left some comments below with possible improvements, mostly small things were a rephrasing could improve readability and comprehension. All-in-all I really have to thank you for your motivation and dedication.
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, some complimenting the existing comments left by Felix.
Some of them are simple errors that make sense to fix, like the missing starting quote. Others require opinions.
|
I added most of the suggestions from your first reviews to the PR, except for the unresolved discussions around breaking change and deprecation/deprecate. I also added to release to the glossary, as I thought it'd be covered by this paragraph from the style guide, so maybe listing it explicitly might be useful to others:
|
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Ich habe noch einige Änderungen vorgeschlagen. Eines davon ist ein Beschreibungsfehler im Glossar, das andere ist nur ein Kommasetzungsfehler.
randomguy-2650
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Es gibt etwas, wozu wir mehr Meinungen brauchen. Das können wir wahrscheinlich besser in Discord besprechen statt hier, wenn nötig.
trueberryless
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments (the suggested changes to the glossary will make change when you first look at the comments in the text), some of them are nitpicky, some opinionated and some fix basic oversights. No rush!
Otherwise, I think we are almost good to approve, I think most discussions are cleared and we have agreed on one opinion 👍
Feel free to request a review again when all comments are resolved (I think some others from randomguy can also be marked as completed already, I just don't have permission)
771c69b to
a559a0f
Compare
|
I added most pending suggestions. @trueberryless care to take another look at the changes and the two unresolved discussions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀
AFAIK all comments and discussions are resolved and we are good to merge, once randomguy approves as well. GitHub shows some random threads for some reason, I'm just gonna ignore them as I think we have everything, right? EDIT: I think GitHub doesn't let me resolve my own comment… Awesome!

Description (required)
Adds German translation for upgrade-astro.mdx and proposes a few new words for the German i18n style guide.
To reviewers: Ich war mir bei einigen Begriffen aus dem Tech-Jargon nicht sicher, ob/wie ich sie übersetzen soll. Einen Teil davon habe ich für das Glossar vorgeschlagen, den Rest (der vmtl. nicht so oft vorkommt) frei Schnauze (aber konsistent) übersetzt. Schaut da also gerne besonders drauf.
Viel Spaß beim Typos finden!