i18n(fr): update integrations-guide/cloudflare.mdx#13472
i18n(fr): update integrations-guide/cloudflare.mdx#13472ArmandPhilippot wants to merge 8 commits intowithastro:mainfrom
integrations-guide/cloudflare.mdx#13472Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ld-web
left a comment
There was a problem hiding this comment.
Just a few comments and a doubt about "to provision", the rest looks good to me !
Co-authored-by: ld-web <46715342+ld-web@users.noreply.github.com>
Co-authored-by: ld-web <46715342+ld-web@users.noreply.github.com>
ld-web
left a comment
There was a problem hiding this comment.
Small suggestions here, the rest looks good !
|
|
||
| ### Modifié : Le fichier de configuration Wrangler est désormais optionnel | ||
|
|
||
| Le fichier de configuration Wrangler est désormais facultatif pour les projets simples. Si vous ne disposez pas d'une configuration personnalisée, telle que des liaisons Cloudflare (KV, D1, Durable Objects, etc.), Astro générera automatiquement une configuration par défaut pour vous. |
There was a problem hiding this comment.
| Le fichier de configuration Wrangler est désormais facultatif pour les projets simples. Si vous ne disposez pas d'une configuration personnalisée, telle que des liaisons Cloudflare (KV, D1, Durable Objects, etc.), Astro générera automatiquement une configuration par défaut pour vous. | |
| Le fichier de configuration Wrangler est désormais facultatif pour les projets simples. Si vous ne disposez pas d'une configuration personnalisée, telle que des liaisons Cloudflare (KV, D1, objets durables, etc.), Astro générera automatiquement une configuration par défaut pour vous. |
Should it be translated everywhere in the guide ? I'm hesitating 🤔
There was a problem hiding this comment.
I'm not sure either. Same for KV.
I don't know if Cloudflare blog posts are auto-translated (probably, I haven't read them in details) or translated by a native speaker, but in https://blog.cloudflare.com/fr-fr/durable-objects-ga/ they seem to translate it, except when it refers to their service (ie. used as a brand).
So, if this is the name of the binding, maybe this one shouldn't be translated?
There was a problem hiding this comment.
yeah, for Cloudflare these are brand names™️, so they shouldn't be translated
There was a problem hiding this comment.
Thanks for the feedback, Yan!
So, I reverted the translation for KV (still a bit torn, because KV is meaningful for native speakers but not for French speakers, but I don't think this hurts much here) and Durable Objects, except in two places where I think it makes the reading a little wonky. And because the Cloudflare blog post translates it in some places... I think it's okay.
If the last commit looks fine for both of you, I think this is one is finally ready to be merged!
There was a problem hiding this comment.
It makes sense that they are brand names, I understand, thanks Yan.
@ArmandPhilippot LGTM !
Co-authored-by: ld-web <46715342+ld-web@users.noreply.github.com>
Description (required)
Adds changes from #12322, #13389, #13417, #13507, and #13466 to the French translation of
integrations-guide/cloudflare.mdx.Related issues & labels (optional)