Skip to content

docs: fix clipped scroll area of sidebar and table of contents #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabian-hiller wants to merge 1 commit into from
Closed

docs: fix clipped scroll area of sidebar and table of contents #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/docs/src/components/docs/DocsSidebar.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ interface Props {
const { groups, currentSlug, mobile = false, groupHeadingLevel = 2 } = Astro.props;
---

<nav class:list={[mobile ? 'static' : 'docs-sidebar-nav sticky top-[calc(var(--docs-header-height)+var(--docs-aside-top))] max-h-[calc(100vh-var(--docs-header-height)-var(--docs-aside-top)-2rem)] overflow-y-auto pr-2']} aria-label="Documentation navigation">
<nav class:list={[mobile ? 'static' : 'docs-sidebar-nav sticky top-[var(--docs-header-height)] max-h-[calc(100vh-var(--docs-header-height))] overflow-y-auto pt-[var(--docs-aside-top)] pr-2 pb-8']} aria-label="Documentation navigation">
{groups.map((group) => <DocsSidebarGroup group={group} currentSlug={currentSlug} mobile={mobile} headingLevel={groupHeadingLevel} />)}
</nav>
2 changes: 1 addition & 1 deletion apps/docs/src/components/docs/DocsTableOfContents.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const { headings } = Astro.props;
---

{headings.length > 1 && (
<nav class="sticky top-[calc(var(--docs-header-height)+var(--docs-aside-top))] max-h-[calc(100vh-var(--docs-header-height)-var(--docs-aside-top)-2rem)] overflow-y-auto pr-2" aria-label="On this page">
<nav class="sticky top-[var(--docs-header-height)] max-h-[calc(100vh-var(--docs-header-height))] overflow-y-auto pt-[var(--docs-aside-top)] pr-2 pb-8" aria-label="On this page">
<p class="mb-3 text-xs font-semibold tracking-wider text-gray-500 uppercase">On this page</p>
<ul class="m-0 list-none p-0">
{headings.map((heading) => <DocsTocItem depth={heading.depth} slug={heading.slug} text={heading.text} />)}
Expand Down
4 changes: 2 additions & 2 deletions apps/docs/src/layouts/DocsLayout.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const formattedReviewedDate = lastReviewedAt?.toLocaleDateString('en-US', {
: 'grid-cols-[254px_minmax(0,820px)_16.5rem] max-2xl:grid-cols-[232px_minmax(0,1fr)]',
]}
>
<aside class="border-r border-docs-border pt-[var(--docs-aside-top)] pr-8 pb-8 pl-5 max-docs-desktop:hidden">
<aside class="border-r border-docs-border pr-8 pl-5 max-docs-desktop:hidden">
<DocsSidebar groups={currentSection.groups} currentSlug={currentSlug} />
</aside>
<main
Expand Down Expand Up @@ -157,7 +157,7 @@ const formattedReviewedDate = lastReviewedAt?.toLocaleDateString('en-US', {
</main>
{
variant === 'default' && (
<aside class="pt-[var(--docs-aside-top)] pr-2 pb-8 pl-7 max-2xl:hidden">
<aside class="pr-2 pl-7 max-2xl:hidden">
{showTableOfContents && <DocsTableOfContents headings={tableOfContents} />}
</aside>
)
Expand Down