chore: add repository and update prettier-plugin-astro#504
chore: add repository and update prettier-plugin-astro#504lvqq wants to merge 3 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: a8f2bbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for your contribution! It seems like there's now 4 versions of the compiler in the lockfile, it'd be great to untangle that while we're there, as otherwise it won't fix the situation happening in main |
|
I agree. It could solve the issue in astro but will make things worse for this repository. What's the suggestion for this issue since there is a cycle in dependencies? @astro/language-server 0.29.6 And @astrojs/compiler is a direct dependency of @astro/language-server, is a indirect dependency of prettier-plugin-astro. For astro repository, a new version of @astro/language-server which depends on a v0.8.0 prettier-plugin-astro is needed |
|
You have few options here. You could start by breaking down this PR into two PRs:
Regarding the update of the dependency: You could make |
|
I don't mind the devDeps at all actually. They're only used in tests to test that we get the types from Astro properly, so it doesn't really matter if we don't have a precise version for them. The main thing is avoiding multiple versions for users. Something to note is that Ideally, the path we'd take is the following:
|
|
@Princesseuh Thanks for your patient reply! I'd move the modification about the repository to another PR |
Changes