Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

chore: add repository and update prettier-plugin-astro#504

Closed
lvqq wants to merge 3 commits intowithastro:mainfrom
lvqq:main
Closed

chore: add repository and update prettier-plugin-astro#504
lvqq wants to merge 3 commits intowithastro:mainfrom
lvqq:main

Conversation

@lvqq
Copy link
Contributor

@lvqq lvqq commented Apr 11, 2023

Changes

@lvqq lvqq requested a review from a team as a code owner April 11, 2023 05:25
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

🦋 Changeset detected

Latest commit: a8f2bbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/language-server Patch
astro-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Princesseuh
Copy link
Member

Princesseuh commented Apr 11, 2023

Thank you for your contribution! It seems like there's now 4 versions of the compiler in the lockfile, it'd be great to untangle that while we're there, as otherwise it won't fix the situation happening in main

@lvqq
Copy link
Contributor Author

lvqq commented Apr 11, 2023

I agree.

It could solve the issue in astro but will make things worse for this repository. What's the suggestion for this issue since there is a cycle in dependencies?

@astro/language-server 0.29.6
-> astro(devDependencies)
-> @astro/language-server 0.28.3(dependencies)

And @astrojs/compiler is a direct dependency of @astro/language-server, is a indirect dependency of prettier-plugin-astro. For astro repository, a new version of @astro/language-server which depends on a v0.8.0 prettier-plugin-astro is needed

@ematipico
Copy link
Member

ematipico commented Apr 11, 2023

@lvqq

You have few options here. You could start by breaking down this PR into two PRs:

  • one where you just update the package.json fields, which are only metadata;
  • anotherwhere you tackle the update of the dependency;

Regarding the update of the dependency:

@astro/language-server 0.29.6
-> astro(devDependencies)
-> @astro/language-server 0.28.3(dependencies)

You could make astro(devDependencies) a dev and optional dependency. Then you could add the peerDependenciesMeta to tell the package manager that the dependency is not mandatory. I think that should help.

@Princesseuh
Copy link
Member

I don't mind the devDeps at all actually. They're only used in tests to test that we get the types from Astro properly, so it doesn't really matter if we don't have a precise version for them.

The main thing is avoiding multiple versions for users. Something to note is that astro cannot currently updates its @astrojs/language-server version until the later reaches 1.0 (#482), because the versions of the package have diverged fairly consequentially.

Ideally, the path we'd take is the following:

@lvqq
Copy link
Contributor Author

lvqq commented Apr 11, 2023

@Princesseuh Thanks for your patient reply! I'd move the modification about the repository to another PR

@lvqq lvqq closed this Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants