Skip to content

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Nov 5, 2025

Description

This PR refactors how Pagefind is run after the build process. Instead of using the CLI via npx, it now uses the Pagefind API directly.

Feature-wise, there should be no changes but one aspect which will differ is logging.

Before After
SCR-20251105-oazh SCR-20251105-ocrn

We are now directly using a fork of the Starlight ingration logger. I didn't spend too much time on tweaking the logging output so far, but one huge difference is that we don't have access to the same informations when using the API vs CLI which access them using some internal Rust code and that data is not exposed via the API.

Personally, I never found the logging output of the CLI very useful, so I think this is an overall improvement but definitely something worth mentioning and discussing if needed.

Todo

  • Add a changeset. (Chris added a temporary one to test preview releases, but we may want to revisit the wording.)

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

🦋 Changeset detected

Latest commit: 2b95224

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 2b95224
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/69692b5508cdce000817529a
😎 Deploy Preview https://deploy-preview-3534--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Nov 5, 2025
@delucis delucis added this to the v0.38 milestone Dec 2, 2025
@delucis delucis added pr-preview Trigger a preview release for this PR using pkg.pr.new and removed pr-preview Trigger a preview release for this PR using pkg.pr.new labels Dec 9, 2025
@delucis delucis added pr-preview Trigger a preview release for this PR using pkg.pr.new and removed pr-preview Trigger a preview release for this PR using pkg.pr.new labels Dec 10, 2025
@delucis delucis added the pr-preview Trigger a preview release for this PR using pkg.pr.new label Dec 10, 2025
@HiDeoo HiDeoo removed the pr-preview Trigger a preview release for this PR using pkg.pr.new label Dec 10, 2025
@HiDeoo HiDeoo added the pr-preview Trigger a preview release for this PR using pkg.pr.new label Dec 10, 2025
@delucis delucis removed the pr-preview Trigger a preview release for this PR using pkg.pr.new label Dec 10, 2025
@HiDeoo HiDeoo added the pr-preview Trigger a preview release for this PR using pkg.pr.new label Dec 10, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

pnpm add https://pkg.pr.new/@astrojs/starlight@3534

commit: 7b632ba

@Mikescops
Copy link

Hello, thanks a lot for the PR, is there a chance this goes into the next version? 😄

@delucis delucis removed the pr-preview Trigger a preview release for this PR using pkg.pr.new label Jan 14, 2026
@delucis
Copy link
Member

delucis commented Jan 14, 2026

is there a chance this goes into the next version?

Yes, planned for v0.38!

@Mikescops
Copy link

Nice, thanks a lot!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HiDeoo! Left a few small comments, but this looks great!

@delucis delucis marked this pull request as ready for review January 14, 2026 17:09
@delucis delucis added the 🌟 minor Change that triggers a minor release label Jan 14, 2026
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and I missed the failing coverage check. Looks like we should add some testing maybe? The new integrations/pagefind.ts file is showing many lines uncovered in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 🌟 minor Change that triggers a minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pagefind forces the use of npx to run which may not be available

3 participants