-
-
Notifications
You must be signed in to change notification settings - Fork 896
Tweak header hover effects #3598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9ac528f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
delucis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change makes sense. It is subtly “breaking” but I think that standardising that increase in contrast everywhere is logical — thanks for the implementation!
I can take care of writing the changeset, given you’re hard at work on v6 stuff!
delucis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the changeset, so this should be ready whenever we want to release the next minor.

As suggested in #3263 (comment), this PR updates the social icons hover effect to use the same hover effect we use in other parts of Starlight rather than relying on an opacity decrease. Turns out that this was something I personally changed in the Rapide theme a while back so definitely happy to have the same effect as default in Starlight.
The second change is updating the select (theme and language switcher) color and hover colors to use a contrast increase rather than a decrease. This matches what we currently do for example in the search bar or mobile table of contents.
As this change was not explicitly requested in the linked comment above, this is done in a separate commit so we can easily revert it if needed.
Remaining tasks