Skip to content

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Dec 2, 2025

As suggested in #3263 (comment), this PR updates the social icons hover effect to use the same hover effect we use in other parts of Starlight rather than relying on an opacity decrease. Turns out that this was something I personally changed in the Rapide theme a while back so definitely happy to have the same effect as default in Starlight.

Before After
Normal SCR-20251202-lend SCR-20251202-leos
Hover SCR-20251202-lenx SCR-20251202-lepf

The second change is updating the select (theme and language switcher) color and hover colors to use a contrast increase rather than a decrease. This matches what we currently do for example in the search bar or mobile table of contents.

As this change was not explicitly requested in the linked comment above, this is done in a separate commit so we can easily revert it if needed.

Before After
Normal SCR-20251202-lggh SCR-20251202-lghm
Hover SCR-20251202-lggw SCR-20251202-lghx

Remaining tasks

  • Add changeset with instructions on how to preserve old behavior (I will only do this after confirming all the changes we want to ship)

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2025

🦋 Changeset detected

Latest commit: 9ac528f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 9ac528f
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/6967be147f512000083e1fc3
😎 Deploy Preview https://deploy-preview-3598--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 2, 2025
@delucis delucis added this to the v0.38 milestone Dec 2, 2025
@delucis delucis added pr-preview Trigger a preview release for this PR using pkg.pr.new and removed pr-preview Trigger a preview release for this PR using pkg.pr.new labels Dec 9, 2025
@delucis delucis added the 🌟 minor Change that triggers a minor release label Jan 14, 2026
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense. It is subtly “breaking” but I think that standardising that increase in contrast everywhere is logical — thanks for the implementation!

I can take care of writing the changeset, given you’re hard at work on v6 stuff!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the changeset, so this should be ready whenever we want to release the next minor.

@delucis delucis added the ✅ approved Pull requests that have been approved and are ready to merge when next cutting a release label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ approved Pull requests that have been approved and are ready to merge when next cutting a release 🌟 core Changes to Starlight’s main package 🌟 minor Change that triggers a minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants