Skip to content

fix: improve theme select legibility in dark mode on Windows Firefox #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dashitongzhi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: improve theme select legibility in dark mode on Windows Firefox #3900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2c4cfd
fix: improve theme select legibility in dark mode on Windows Firefox
dashitongzhi May 12, 2026
5b5a6ec
fix: scope dark mode select fix to Firefox only, preserve transparent…
dashitongzhi May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/starlight/components/Select.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,28 @@ interface Props {
color: var(--sl-color-gray-1);
}

/*
* Firefox on Windows renders native select option dropdowns with
* incorrect colors in dark mode — option backgrounds appear white
* and checked/hovered text is invisible. Use @supports to target
* Firefox (-moz-appearance) so other browsers are unaffected.
* Only fix option backgrounds, not the select itself, to preserve
* transparent backgrounds on pages like the homepage.
* See: https://github.com/withastro/starlight/issues/3426
*/
@supports (-moz-appearance: none) {
:global([data-theme='dark']) select option,
:global([data-theme='dark']) select option:checked {
background-color: var(--sl-color-bg-nav);
color: var(--sl-color-text);
}

:global([data-theme='dark']) select option:hover {
background-color: var(--sl-color-accent-high);
color: var(--sl-color-text-invert);
}
}

@media (min-width: 50rem) {
select {
font-size: var(--sl-text-sm);
Expand Down