feat: Generate shell completions on install#3
feat: Generate shell completions on install#3jalaziz wants to merge 1 commit intowithgraphite:masterfrom
Conversation
31746b5 to
295d3c7
Compare
295d3c7 to
d52c23e
Compare
|
@dbalatero @goldjacobe Sorry to be a pest and ping you directly, but any chance this could be reviewed? This helps simply the graphite CLI install to a single step. |
d52c23e to
b18db02
Compare
b18db02 to
5555c43
Compare
|
Thanks for these PRs, I'll integrate soon (we have some other inflight changes to the release process I want to finalize first) |
|
this diff doesn't seem to work as expected. |
|
@goldjacobe What issue are you seeing? No completions installed? I had run into some issues during the last rebased, but thought I fixed everything. I'm rebasing to test again. |
Homebrew can automatically generate and install completions for bash, zsh, and fish. For now, completion is limited to bash and zsh until graphite adds fish support. This simplifies the installation steps for homebrew users.
5555c43 to
c880a52
Compare
|
@goldjacobe I just rebased and tested and it's installing the shell completions for me (I'm using zsh). Are you not seeing completions installed? For zsh, the shell completions are installed to |
Homebrew can automatically generate and install completions for bash,
zsh, and fish. For now, completion is limited to bash and zsh until
graphite adds fish support.
This simplifies the installation steps for homebrew users.