Swap real/imag constants for negative G2 generator #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit brings the G2_NEG_* constants into conformance with https://eips.ethereum.org/EIPS/eip-197 It also ensures G2_NEG is on the curve.
Contributor
|
Hi @nikeshnazareth ! Thanks for discovering it! Do you mind rebasing the pull request with the master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The G2_NEG constants have the imaginary and real components switched.
This commit brings the G2_NEG_* constants into conformance with
https://eips.ethereum.org/EIPS/eip-197
It also ensures G2_NEG is on the curve.