Skip to content

Conversation

@k06a
Copy link

@k06a k06a commented Sep 21, 2023

MODEXP precompile always return success, but returndatasize() is 0 on failure.

Few more things to consider:

  • Include sub(n, 2) underflow check into success: success := and(gt(n, 1), eq(returndatasize(), 0x20))
  • Using 0 instead of freemem for call output memory pointer will be few gas cheaper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant