refactor(ui): avoid store class instances in vuex #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
force-pushed
the
remove-classes-state
branch
from
ef79b4a to
31dd173
Compare
We should only store plain objects in vuex to avoid not being able to call the class instance methods
Tommytrg
force-pushed
the
remove-classes-state
branch
from
31dd173 to
a3cbb52
Compare
gabaldon
suggested changes
Nov 11, 2022
Collaborator
gabaldon
left a comment
gabaldon
left a comment
There was a problem hiding this comment.
You should also update context.rootState.wallet.api.getItem and context.rootState.wallet.api.saveItem in rad.js. The wallet api is not anymore in wallet.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.