Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enable Radon scripts to run on binary sources #2406

Open
wants to merge 19 commits into
base: 2.0-base
Choose a base branch
from

Conversation

guidiaz
Copy link
Contributor

@guidiaz guidiaz commented Oct 20, 2023

No description provided.

@guidiaz guidiaz changed the base branch from master to 2.0-base October 20, 2023 10:47
rad/src/lib.rs Outdated
let (parts, mut body) = response.into_parts();

let response: RadonTypes;
match parts.headers.get("accept-ranges") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you only what to check for presence and not for value, you can do ``cointains_key`.

rad/src/lib.rs Outdated
let mut response_bytes = Vec::<u8>::default();
match retrieve.kind {
RADType::HttpHead => {
// todo: assert http-head responses should never return binary streams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created RadonError response containing RadError::BufferIsNotValue struct.

Copy link
Member

@aesedepece aesedepece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, but will need TAPI guards. Let's leave it open for now and merge once 2.0 TAPI guards are implemented on the 2.0 integration branch.

@guidiaz
Copy link
Contributor Author

guidiaz commented Feb 23, 2024

witnet/WIPs#99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants