Fix ethereum mainnet v2.2 - #479
Merged
Merged
Conversation
…bytecode is outdated
guidiaz
force-pushed
the
fix-ethereum-mainnet-v2.2
branch
from
October 9, 2025 10:34
9a560a3 to
502c0a3
Compare
…racleLegacy.Query* structs
Tommytrg
approved these changes
Oct 14, 2025
| ) | ||
| const depsImplAddr = await determineTargetAddr(depsImpl, depsImplSpecs, networkArtifacts) | ||
| let depsImplAddr = utils.getNetworkArtifactAddress(network, domain, addresses, depsImpl) | ||
| if (utils.isNullAddress(depsImplAddr)) { |
Contributor
There was a problem hiding this comment.
Although the artifact checked here is immutable, utils.getNetworkArtifactAddress may return truthy value from the default section that it could be the wrong netwrok address. We may need to check if it is null or is the valid one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.