Multiple scenes with same viewSource support (+ exit-crossing) - #7
Draft
ameerabuf wants to merge 14 commits into
Draft
Multiple scenes with same viewSource support (+ exit-crossing)#7ameerabuf wants to merge 14 commits into
ameerabuf wants to merge 14 commits into
Conversation
ameerabuf
marked this pull request as draft
August 19, 2024 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use groupId instead of grouping using the viewSource, to avoid comparing HTMLElements but also to avoid combining animations that come from different effects which might be problematic. The intent is to write the viewSource id in the groupId field from outside.