[CMS] - implemented filter #395
Merged
+714
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanlaor
reviewed
Oct 15, 2025
packages/headless-components/cms/src/react/core/CmsCollectionFilters.tsx
Outdated
Show resolved
Hide resolved
bnGil
force-pushed
the
gil/implement-filter
branch
from
9446a21 to
75eedac
Compare
yehuda23
reviewed
Oct 27, 2025
| case '$lte': | ||
| wixFilter = wixFilter.le(fieldPath, operandValue as any); | ||
| break; | ||
| case '$in': |
There was a problem hiding this comment.
why $in case uses hasSome(), we already have case for $hasSome. and if we don't have in operator on filter, then we should not use it, the $in case is for other verticals who supports $in operator (e.g. stores: https://dev.wix.com/docs/sdk/backend-modules/stores/catalog-v3/products-v3/products-query-builder/in)
yehuda23
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.