OLO: headless form modifiers #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and enhance modifier selection handling
…t for improved rendering
…roup and modifiers to item details components
…nto headless-modifiers
naomiwix
approved these changes
Oct 26, 2025
lironas
reviewed
Oct 26, 2025
Comment on lines
+195
to
+218
| if (singleSelect) { | ||
| // Single select behavior: select the modifier, replacing any existing selection | ||
| selectedModifiers.set({ | ||
| ...currentSelectedModifiers, | ||
| [modifierGroupId]: [modifierId], | ||
| }); | ||
| } else { | ||
| // Multi-select behavior: toggle the modifier | ||
| if (isModifierSelected) { | ||
| // Remove the modifier if it exists | ||
| const updatedModifierIds = groupModifierIds.filter( | ||
| (id) => id !== modifierId, | ||
| ); | ||
| selectedModifiers.set({ | ||
| ...currentSelectedModifiers, | ||
| [modifierGroupId]: updatedModifierIds, | ||
| }); | ||
| } else { | ||
| // Add the modifier to the existing selection | ||
| selectedModifiers.set({ | ||
| ...currentSelectedModifiers, | ||
| [modifierGroupId]: [...groupModifierIds, modifierId], | ||
| }); | ||
| } |
There was a problem hiding this comment.
to complicated, I'd at least separate the modifierIds to update and the set(...)
something like
const modifierIds = getUpdatedModifiers();
selectedModifiers.set({
...currentSelectedModifiers,
[modifierGroupId]: modifierIds,
});
Comment on lines
+225
to
+229
| // Get selected modifier IDs for this group | ||
| const groupId = modifierGroup._id; | ||
| const groupSelectedModifierIds = groupId | ||
| ? selectedModifiers[groupId] || [] | ||
| : []; |
There was a problem hiding this comment.
I think it better to move the logic to the service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.