Skip to content

Conversation

@naomiwix
Copy link

#pr

@naomiwix naomiwix changed the base branch from master to main October 26, 2025 12:55
@naomiwix naomiwix marked this pull request as draft October 26, 2025 12:56
Comment on lines +255 to +258
availabilityStatusText: string;
availabilityStatusButtonText: string;
shouldShowAvailabilityStatusText: boolean;
shouldShowAvailabilityStatusButton: boolean;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe cleaner API for that component

availabilityStatusText = null or empty string will now show availability
availabilityCTA = {
text: string empty or null will not show text
openModal: () => void;
className?: string;
asChild?: boolean;
}
}

I tink that is availabilityStatusText or am I missing something
the only option you have is show button or not if not showing you don't need the button
and you are not openModal


operationId?: string;
availabilityStatus?: {
isMenuOfItemAvailable?: boolean;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that I understand what this Flag mean

Comment on lines 23 to 33
item?: Signal<EnhancedItem | undefined>;
quantity: Signal<number>;
specialRequest: Signal<string>;
shouldShowAvailabilityStatusText: Signal<boolean>;
availabilityStatusText: Signal<string>;
availabilityStatusButtonText: Signal<string>;
shouldShowAvailabilityStatusButton: Signal<boolean>;
openAvailabilityModal: Signal<() => void>;
lineItem: Signal<LineItem>;
selectedVariant: Signal<Variant | undefined>;
selectedModifiers: Signal<Record<string, Array<string>>>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that nested the data of item could make this api clearer
itemData {
operationId?: string;
itemId?: string;
item?: Signal<EnhancedItem | undefined>;
lineItem: Signal;
}
userSelection/Preference {
quantity: Signal;
specialRequest: Signal;
variant: Signal<Variant | undefined>;
modifiers: Signal<Record<string, Array>>;
}

@id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants