Ocr tool for appium driver #153
Conversation
| logger | ||
| .labeled("CODE") | ||
| .info(`Running code:`, matchingEntry.value.code); |
There was a problem hiding this comment.
There was a problem hiding this comment.
also, we might want to extract the log to some function (const logCodeExec = (code: string) => { ...), since we're using this on line 117 as well. Also I think we should color the code in grey so it won't be very annoying on the logs
There was a problem hiding this comment.
Isn't this log enough? https://github.com/wix-incubator/pilot/blob/master/packages/core/src/common/CodeEvaluator.ts#L20-L24
It is needed in cases where the code fails to execute and there is no indication of what code was actually trying to run.
There was a problem hiding this comment.
also, we might want to extract the log to some function (
const logCodeExec = (code: string) => { ...), since we're using this on line 117 as well. Also I think we should color the code in grey so it won't be very annoying on the logs
| ], | ||
|
|
||
| logLevel: "info", | ||
| logLevel: "warn", |
There was a problem hiding this comment.
info is for logging the view hierarchy. I don't think it's needed.
packages/drivers/appium/index.ts
Outdated
| const tempImagePath = path.join(__dirname, "temp_screenshot.png"); | ||
| writeFileSync(tempImagePath, base64Image, { encoding: "base64" }); |
There was a problem hiding this comment.
it saves the temp file in the current directory, always under the same name.
it will be a problem when running in parallel, also it should be stored under the temp dir (os.tmpdir()). and use a unique name for each snapshot.
There was a problem hiding this comment.
futhermore, it might be better to use the existing method for taking snapshot from the testing framework driver. WDYT?
| /** | ||
| * Removes near-duplicate coordinates based on a small epsilon threshold | ||
| */ | ||
| function deduplicateCoordinates( |
There was a problem hiding this comment.
In case of 2 images returns the same location.
Co-authored-by: Asaf Korem <[email protected]>
2 participants
No description provided.