fix: locate test file path #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafkorem
requested changes
Jun 25, 2025
| error instanceof Error ? error.message : String(error); | ||
|
|
||
| logger.labeled("ERROR").error(`Execution failed: ${errorMessage}`); | ||
| await logger.labeled("ERROR").error(`Execution failed: ${errorMessage}`); |
There was a problem hiding this comment.
do we really need this to be async-await now?
Comment on lines
+40
to
+49
| // A wrapper function to make sure that failing test is not saved to cache. | ||
| // const wrapTest = (fn: () => Promise<void>) => | ||
| // async function () { | ||
| // try { | ||
| // await fn(); | ||
| // } catch (err) { | ||
| // testFailed = true; | ||
| // throw err; | ||
| // } | ||
| // }; |
| private cacheOptions?: CacheOptions; | ||
| private snapshotComparator: SnapshotComparator; | ||
| private codeEvaluator: CodeEvaluator; | ||
| private resolvedCacheFilePath?: string; |
# Conflicts: # package-lock.json
The line this.cacheFilePath = this.determineCurrentCacheFilePath(); was added back to loadCacheFromFile() to handle cases like Detox. Additionally, getCacheFilePath() was updated so that if getCurrentTestFileFromStackTrace() returns undefined, it first checks whether a path already exists before falling back to the default path.
After running in appium-test, still working.
LironMShemen
commented
Jul 3, 2025
packages/core/src/Pilot.ts
Outdated
| */ | ||
| async perform(...steps: string[]): Promise<any> { | ||
| this.loadCache(); | ||
| await this.loadCache(); |
There was a problem hiding this comment.
check why do we need that
Comment on lines
361
to
374
| const cacheFilePath = (newCacheHandler as any).cacheFilePath; | ||
| const cacheFilePath = await (newCacheHandler as any).cacheFilePath; |
There was a problem hiding this comment.
check if needed
| this.cacheFilePath = this.determineCurrentCacheFilePath(); | ||
|
|
There was a problem hiding this comment.
we need the await on this function
LironMShemen
commented
Jul 6, 2025
Comment on lines
299
to
300
| progress: async () => { | ||
| await this.logWithLabel("info", label, "Starting"); |
There was a problem hiding this comment.
probably missed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the path of the currently running test across all test runners, so the cache can be saved there.