Skip to content

fix(ios): make it possible to install via CocoaPods - #276

Closed
sondremare wants to merge 5 commits into
wix-incubator:masterfrom
sondremare:master
Closed

fix(ios): make it possible to install via CocoaPods#276
sondremare wants to merge 5 commits into
wix-incubator:masterfrom
sondremare:master

Conversation

@sondremare

Copy link
Copy Markdown
Contributor

The podspec file was npm ignored, resulting in linking via CocaPods did not work

The podspec file was npm ignored, resulting in linking via CocaPods did not work
@rgoldiez

Copy link
Copy Markdown

Why would this not be merged?

@DaBs

DaBs commented Jul 17, 2019

Copy link
Copy Markdown

This is critical to merge for React Native 0.60 :)

@congnguyen91

Copy link
Copy Markdown

+1

@ahanriat

Copy link
Copy Markdown
Contributor

@Inbal-Tish Friendly ping 🤗

@ammichael

Copy link
Copy Markdown

@Inbal-Tish could you please give a look at this PR? this is crucial to anyone upgrading to RN 0.60. thanks a lot!

@alexichristakis

Copy link
Copy Markdown

I've just installed from master in the interim to include the podspec

@mtzfactory

Copy link
Copy Markdown

Yeah, that's crucial!

@brandons

brandons commented Sep 30, 2019

Copy link
Copy Markdown

Bumping. @Inbal-Tish Can we get this approved?

@keithhackbarth

Copy link
Copy Markdown

BUMP!!!!!

@darran-kelinske-fivestars

Copy link
Copy Markdown

bump again <3

@Inbal-Tish

Copy link
Copy Markdown
Contributor

@sondremare The Android build is failing.

@Inbal-Tish
Inbal-Tish requested a review from rotemmiz October 22, 2019 08:29
@ammichael

Copy link
Copy Markdown

Is this repo dead? This PR was opened 7 months ago and it changes 3 lines. Seriously no one can test and approve it? It clearly has nothing to do with Android build.

@rotemmiz

rotemmiz commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

Redone in #300 - Original PR had some git reference messup (detached head, unreachable by CI, caused this PR build to fail).
I am closing this PR in favour of #300. Thanks for your contribution @sondremare, we'll make sure this is merged and published ASAP.

@rotemmiz rotemmiz closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.