fix(types): remove non-existent empty property from SlotKey type
#301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face Remove `empty` property from an `SlotKey` type because the property doesn't really exist at runtime,so we're ensuring type definitions accurately reflect the actual object structure.
IdoBouskila
commented
Apr 4, 2025
| * Holds no value, only triggers type-checking of T | ||
| */ | ||
| readonly empty?: T | ||
| export interface SlotKey<_T> extends AnySlotKey { |
Author
There was a problem hiding this comment.
The underscore prefix (_T ) is used to tell TS to ignore unused parameters :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
emptyproperty fromSlotKeytype because the property doesn't really exist at runtime, so we're ensuring type definitions accurately reflect the actual object structure in runtimePlayground: https://tsplay.dev/wgO8yw