Run before #10
Open
Run before #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add documentation |
shlomitc
reviewed
Feb 2, 2020
| <p>Story will appear to not be ready without the <pre style={{display: 'inline'}}>runBefore</pre> script</p> | ||
| </div>, | ||
| async ({ rootEl }) => { | ||
| const img = rootEl.querySelector('img') as HTMLImageElement; |
There was a problem hiding this comment.
any reason not to write a react code here?
There was a problem hiding this comment.
This is code that eyes-storybook runs in the browser.
So i'm not sure it will be possible.
Also there's no way to debug this: applitools/eyes-storybook#30
|
I'm also missing some documentation if it's a public API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
runBefore: https://github.com/applitools/eyes-storybook#runBefore