Open
Conversation
…47) * only filters labels according to parent packages for LanguageClass.C This is to keep supporting CPP need while also supporting aggregate targets More info: https://bazelbuild.slack.com/archives/CM8JQCANN/p1566481600003600 Filter was deliberately added to fix an issue with C++ headers. The original bug was that opening the BUILD file for foo/bar.h caused it to open baz/qux/BUILD because there’s a cc_library target in baz/qux that includes foo/bar.h in its headers. The source-to-target look up queries the index for the target during the last sync which compiled the source file. In this case, it was the cc_library target in baz/qux. So the fix was to ensure that the BUILD file is always for the parent package (foo/bar)
Don't use ijars as they break source navigation - ignore java_import /_ijar/ as its original location is not know - replace -ijar with sibling full jar - replace -hjar with sibling full jar https://youtrack.jetbrains.com/issue/SCL-16975/Navigation-to-attached-Scala-sources-for-interface-jar-does-not-work
Add support for scala source attachment
Add source root detection for Java and Scala source jars. Detection is required when dire4ctory structure in source jar has deeper structure than source packages. Source attachement changes for 2022.3 support
`idea.plugin.protoeditor` needs to be aware of source roots of proto libraries Add proto files to target sources
Via running bloop and BSP
for some reason without the + the runfiles dir isn't created this is something that native rules don't suffer from another alternative is to add the _hidden_top_level_INTERNAL_ output group
Location substituion supports runpath(s) in addition to location(s) Still includes a hack of the env variable of BUILD_TOOL which we need to see how to remove but at least a smaller hack than before
Author
|
Maybe worth not merging this for now until I finish iterating with Karolis on this. |
Author
|
@mildagle would appreciate your 2c on this PR |
liucijus
force-pushed
the
wix-master
branch
2 times, most recently
from
bd43a7c to
9911945
Compare
WixBuildServer
force-pushed
the
wix-master
branch
2 times, most recently
from
e09e9c3 to
915bf19
Compare
WixBuildServer
force-pushed
the
wix-master
branch
2 times, most recently
from
e08d2e9 to
47847e3
Compare
WixBuildServer
force-pushed
the
wix-master
branch
3 times, most recently
from
d9d6faf to
46c582d
Compare
mildagle
force-pushed
the
wix-master
branch
2 times, most recently
from
18bf513 to
9b98f4f
Compare
WixBuildServer
force-pushed
the
wix-master
branch
5 times, most recently
from
5a27430 to
27c92f2
Compare
WixBuildServer
force-pushed
the
wix-master
branch
5 times, most recently
from
b3695c3 to
c5c252f
Compare
WixBuildServer
force-pushed
the
wix-master
branch
3 times, most recently
from
3413b0f to
dd80eb3
Compare
WixBuildServer
force-pushed
the
wix-master
branch
2 times, most recently
from
3648427 to
ffadbd7
Compare
WixBuildServer
force-pushed
the
wix-master
branch
2 times, most recently
from
a5c8d21 to
52247ad
Compare
WixBuildServer
force-pushed
the
wix-master
branch
2 times, most recently
from
bd65fb3 to
2c3ca42
Compare
WixBuildServer
force-pushed
the
wix-master
branch
3 times, most recently
from
8217180 to
39d4778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added more info on failure from BspJob compile result, also lowered timeout time
I'd love concrete feedback on the code.
Java/Scala future interop is not great and my java toolbox is definitely poorer compared to my scala one.