feat(config): default app permissions (iOS) #3493
Conversation
noomorph
force-pushed
the
feat/app-permissions
branch
2 times, most recently
from
8de310e to
c17d481
Compare
noomorph
force-pushed
the
feat/app-permissions
branch
from
c17d481 to
056704b
Compare
| await this.deviceDriver.installApp(currentApp.binaryPath, currentApp.testBinaryPath); | ||
| if (!_.isEmpty(currentApp.permissions)) { | ||
| await this.deviceDriver.setPermissions(currentApp.bundleId, currentApp.permissions); | ||
| } |
There was a problem hiding this comment.
Well I didn't go deeply into this but something about this approach feels a bit off. It assumes that the permissions can be set in such a global way - before an instance of the app is launched. While it works on iOS, I can't 100% say the same about Android / a theoretical future platform.
What about applying a similar solution to the launch-args technique, which is set in advance and handled on-site (i.e. in launch app)?
| @@ -201,6 +202,7 @@ declare global { | |||
| build?: string; | |||
| testBinaryPath?: string; | |||
| launchArgs?: Record<string, any>; | |||
| permissions?: DevicePermissions; | |||
|
|
||
| | Permission | Values | | ||
| |---------------|---------------------------------------------------------| | ||
| | calendar | `'YES' | 'NO' | 'unset'` | |
There was a problem hiding this comment.
&124; doesn't seem to render well
| @@ -528,3 +530,32 @@ Exposes [`UiAutomator`’s `UiDevice` API](https://developer.android.com/referen | |||
| **This is not a part of the official Detox API**, it may break and change whenever an update to `UiDevice` or `UiAutomator` Gradle dependencies (`androidx.test.uiautomator:uiautomator`) is introduced. | |||
|
|
|||
| [`UiDevice`’s autogenerated code](https://github.com/wix/Detox/tree/a9a09246c05733f6b91cfcc0dba05a4714abca92/detox/src/android/espressoapi/UIDevice.js) | |||
|
|
|||
| ### Permissions (iOS only) | |||
|
|
||
| When you are [configuring the apps](APIRef.Configuration.md#apps-configurations) list in your | ||
| Detox config file or [launching the app](#2-permissionsset-runtime-permissions-ios-only), | ||
| you can give certain permissions beforehand to it to avoid this inconvenient modal: |
There was a problem hiding this comment.
A simple and elegant explanation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
The issue has been closed for inactivity. |
Description
Resolves #2978.